Skip to content

Remove redundant tab in page header #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 25, 2025
Merged

Remove redundant tab in page header #7

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cdd3410
remove redundant tab in page header
GenosseOtt Mar 19, 2025
303e7ae
Merge branch 'main' into cleanup-projects-page
andreaskienle Mar 21, 2025
43576d9
Remove unused import
andreaskienle Mar 21, 2025
ab73cba
Merge branch 'main' into cleanup-projects-page
andreaskienle Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/components/Projects/ProjectsList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { projectnameToNamespace } from '../../utils/index';
import '@ui5/webcomponents-icons/dist/copy';
import '@ui5/webcomponents-icons/dist/arrow-right';
import { ListProjectNames } from '../../lib/api/types/crate/listProjectNames';
import { t } from 'i18next';

export default function ProjectsList() {
const navigate = useLuigiNavigate();
Expand All @@ -21,9 +22,10 @@ export default function ProjectsList() {
return (
<>
<AnalyticalTable
style={{ margin: '12px' }}
columns={[
{
Header: 'Projects',
Header: t('ProjectsListView.title'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

accessor: 'projectName',
Cell: (instance: any) => (
<div
Expand Down
10 changes: 2 additions & 8 deletions src/views/ProjectList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
import {
ObjectPage,
ObjectPageSection,
ObjectPageTitle,
} from '@ui5/webcomponents-react';
import { ObjectPage, ObjectPageTitle } from '@ui5/webcomponents-react';
import ProjectsList from '../components/Projects/ProjectsList.tsx';
import IntelligentBreadcrumbs from '../components/Core/IntelligentBreadcrumbs.tsx';
import { ProjectListToolbar } from '../components/Projects/ProjectListToolbar.tsx';
Expand All @@ -22,9 +18,7 @@ export default function ProjectsListView() {
/>
}
>
<ObjectPageSection id="projects" titleText={t('ProjectsListView.title')}>
<ProjectsList />
</ObjectPageSection>
<ProjectsList />
</ObjectPage>
);
}