Skip to content

Conversation

GenosseOtt
Copy link
Contributor

  • Rename to full product again (MCP is an abbreviation we avoid in end-user-facing contexts)
  • Apply mono touch to indicate its referring to the CR ManagedControlPlane
image

@andreaskienle
Copy link
Contributor

andreaskienle commented Mar 21, 2025

I fixed the merged conflicts.

We can keep the global class for now until we decide on a styling approach.

@GenosseOtt Technically, the CR is ManagedControlPlane rather than ManagedControlPlanes (s), isn’t it? So the heading should be “ManagedControlPlanes”, if we’re being precise 😆 To get around this, how about “Your instances of ManagedControlPlane” or “Your ManagedControlPlane instances”? If you want to keep it that way, also fine, it’s just my inner perfectionist speaking 😆

@GenosseOtt
Copy link
Contributor Author

Noooo. Never apologize for caring for details. Not my biggest strength.
Big fan of: Your instances of ManagedControlPlane. 👍

@andreaskienle
Copy link
Contributor

@GenosseOtt Have a look:

image

Copy link
Contributor Author

@GenosseOtt GenosseOtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ManagedControlPlane we dont use with whitespace (to keep the mental bridge to the Kubernetes Ressourece "ManagedControlPlane" as obvious as possible

@enrico-kaack-comp enrico-kaack-comp merged commit b76ab2c into main Mar 28, 2025
4 checks passed
@enrico-kaack-comp enrico-kaack-comp deleted the mono-font branch March 28, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants