Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions app/common/customer.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import (
customerservice "github.com/openmeterio/openmeter/openmeter/customer/service"
customerservicehooks "github.com/openmeterio/openmeter/openmeter/customer/service/hooks"
entdb "github.com/openmeterio/openmeter/openmeter/ent/db"
entitlementvalidator "github.com/openmeterio/openmeter/openmeter/entitlement/validators/customer"
"github.com/openmeterio/openmeter/openmeter/registry"
"github.com/openmeterio/openmeter/openmeter/subject"
"github.com/openmeterio/openmeter/openmeter/watermill/eventbus"
Expand All @@ -27,7 +26,6 @@ var Customer = wire.NewSet(
func NewCustomerService(
logger *slog.Logger,
db *entdb.Client,
entRegistry *registry.Entitlement,
eventPublisher eventbus.Publisher,
) (customer.Service, error) {
customerAdapter, err := customeradapter.New(customeradapter.Config{
Expand All @@ -46,14 +44,6 @@ func NewCustomerService(
return nil, fmt.Errorf("failed to create customer service: %w", err)
}

// Create and register the entitlement validator
validator, err := entitlementvalidator.NewValidator(entRegistry.EntitlementRepo)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not sure if there's a service where customer svc is used but not entitlement, but if there is, customer svc should still have the entitlement validator, which it won't after this change

if err != nil {
return nil, fmt.Errorf("failed to create entitlement validator: %w", err)
}

service.RegisterRequestValidator(validator)

return service, nil
}

Expand Down
19 changes: 17 additions & 2 deletions app/common/entitlement.go
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
package common

import (
"fmt"
"log/slog"

"github.com/google/wire"
"go.opentelemetry.io/otel/trace"

"github.com/openmeterio/openmeter/app/config"
"github.com/openmeterio/openmeter/openmeter/customer"
entdb "github.com/openmeterio/openmeter/openmeter/ent/db"
entitlementvalidator "github.com/openmeterio/openmeter/openmeter/entitlement/validators/customer"
"github.com/openmeterio/openmeter/openmeter/meter"
"github.com/openmeterio/openmeter/openmeter/registry"
registrybuilder "github.com/openmeterio/openmeter/openmeter/registry/builder"
Expand All @@ -29,15 +32,27 @@ func NewEntitlementRegistry(
meterService meter.Service,
eventPublisher eventbus.Publisher,
locker *lockr.Locker,
) *registry.Entitlement {
return registrybuilder.GetEntitlementRegistry(registrybuilder.EntitlementOptions{
customerService customer.Service,
) (*registry.Entitlement, error) {
entRegistry := registrybuilder.GetEntitlementRegistry(registrybuilder.EntitlementOptions{
DatabaseClient: db,
StreamingConnector: streamingConnector,
MeterService: meterService,
CustomerService: customerService,
Logger: logger,
Publisher: eventPublisher,
EntitlementsConfiguration: entitlementConfig,
Tracer: tracer,
Locker: locker,
})

// Create and register the entitlement validator
validator, err := entitlementvalidator.NewValidator(entRegistry.EntitlementRepo)
if err != nil {
return nil, fmt.Errorf("failed to create entitlement validator: %w", err)
}

customerService.RegisterRequestValidator(validator)

return entRegistry, nil
}
35 changes: 22 additions & 13 deletions cmd/balance-worker/wire_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

38 changes: 23 additions & 15 deletions cmd/billing-worker/wire_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

52 changes: 29 additions & 23 deletions cmd/jobs/internal/wire_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading