feat: robust logging #289
Merged
feat: robust logging #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vertex451
commented
Jul 30, 2025
vertex451
commented
Jul 30, 2025
On-behalf-of: @SAP [email protected] Signed-off-by: Artem Shcherbatiuk <[email protected]> fixed linter On-behalf-of: @SAP [email protected] Signed-off-by: Artem Shcherbatiuk <[email protected]> fixed linter On-behalf-of: @SAP [email protected] Signed-off-by: Artem Shcherbatiuk <[email protected]> fixed tests On-behalf-of: @SAP [email protected] Signed-off-by: Artem Shcherbatiuk <[email protected]> passing logger as a receiver field On-behalf-of: @SAP [email protected] Signed-off-by: Artem Shcherbatiuk <[email protected]> removed not used code On-behalf-of: @SAP [email protected] Signed-off-by: Artem Shcherbatiuk <[email protected]> fixed integration On-behalf-of: @SAP [email protected] Signed-off-by: Artem Shcherbatiuk <[email protected]> fixed test On-behalf-of: @SAP [email protected] Signed-off-by: Artem Shcherbatiuk <[email protected]> added test files to testingore On-behalf-of: @SAP [email protected] Signed-off-by: Artem Shcherbatiuk <[email protected]> fix(deps): update module github.com/golang-jwt/jwt/v5 to v5.3.0 (#291) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> On-behalf-of: @SAP [email protected] Signed-off-by: Artem Shcherbatiuk <[email protected]> fix task cover On-behalf-of: @SAP [email protected] Signed-off-by: Artem Shcherbatiuk <[email protected]>
On-behalf-of: @SAP [email protected] Signed-off-by: Artem Shcherbatiuk <[email protected]>
…into feat/logging
pteich
requested changes
Jul 30, 2025
There was a problem hiding this comment.
I left some suggestions and questions.
Not related to this PR and maybe an oversight of a previous on: Why do we have a pkg sub-package under listener? It feels misplaced, maybe just move the two included packages out of it and align with gateway.
The original idea behind pkg is to have a common place in your repo for packages that could also used externally (in contrast to the internal folder) but it's fully optional.
| @@ -298,6 +300,9 @@ func TestResolveSchema(t *testing.T) { | |||
|
|
|||
| for _, tc := range tests { | |||
| t.Run(tc.name, func(t *testing.T) { | |||
| log, err := logger.New(logger.DefaultConfig()) | |||
There was a problem hiding this comment.
i already mentioned the github.com/openmfp/golang-commons/logger/testlogger package with a compatible logger just for tests.
| @@ -90,13 +87,15 @@ func CheckClusterAccessCRDStatus(ctx context.Context, k8sClient client.Client, l | |||
|
|
|||
| // ClusterAccessReconciler handles reconciliation for ClusterAccess resources | |||
| type ClusterAccessReconciler struct { | |||
| lifecycleManager *lifecycle.LifecycleManager | |||
| opts reconciler.ReconcilerOpts | |||
| client.Client | |||
There was a problem hiding this comment.
Why embed the client and not use a struct var like in APIBindingReconciler?
There was a problem hiding this comment.
It turned out that this field is not used.
Removed.
…into feat/logging On-behalf-of: @SAP [email protected] Signed-off-by: Artem Shcherbatiuk <[email protected]>
On-behalf-of: @SAP [email protected] Signed-off-by: Artem Shcherbatiuk <[email protected]>
On-behalf-of: @SAP [email protected] Signed-off-by: Artem Shcherbatiuk <[email protected]>
On-behalf-of: @SAP [email protected] Signed-off-by: Artem Shcherbatiuk <[email protected]>
On-behalf-of: @SAP [email protected] Signed-off-by: Artem Shcherbatiuk <[email protected]>
pteich
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR - making logging more robust.
Changes
if receiver.log != nil { receiver.log(error)}. This caused the biggest changes, because we had places where logger is not passed from top level.Testing