Skip to content

fix: map metadata to objectmeta #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 31, 2025
Merged

fix: map metadata to objectmeta #292

merged 7 commits into from
Jul 31, 2025

Conversation

vertex451
Copy link
Member

@vertex451 vertex451 commented Jul 30, 2025

Resolves #102

Changes

In case of empty objects with no fields, assign a StringScalar type to it. Works on retrieve and create requests.

Testing

  1. Didn't manage to create a Marketplace entry to test the nested metadata because of some limitation, that is why I tested by temporary forcing metav1.ObjectMeta to be a stringScalar - created a configMap using JSON-string.
    After testing return metav1.ObjectMeta to be metav1.ObjectMeta.
Screenshot 2025-07-31 at 12 17 48
  1. Retrieved a ConfigMaps, and took its metadata and checked if this string can be converted to JSON.

On-behalf-of: @SAP [email protected]

On-behalf-of: @SAP [email protected]
Signed-off-by: Artem Shcherbatiuk <[email protected]>
@vertex451 vertex451 changed the title map metadata to objectmeta fix: map metadata to objectmeta Jul 30, 2025
@vertex451 vertex451 marked this pull request as ready for review July 30, 2025 17:32
@vertex451 vertex451 requested a review from a team as a code owner July 30, 2025 17:32
@vertex451 vertex451 self-assigned this Jul 30, 2025
@vertex451 vertex451 added this to the 2025.Q3 milestone Jul 30, 2025
On-behalf-of: @SAP [email protected]
Signed-off-by: Artem Shcherbatiuk <[email protected]>
On-behalf-of: @SAP [email protected]
Signed-off-by: Artem Shcherbatiuk <[email protected]>
@vertex451 vertex451 closed this Jul 31, 2025
On-behalf-of: @SAP [email protected]
Signed-off-by: Artem Shcherbatiuk <[email protected]>
@vertex451 vertex451 reopened this Jul 31, 2025
@vertex451 vertex451 requested a review from nexus49 July 31, 2025 10:32
@nexus49 nexus49 merged commit 64e5552 into main Jul 31, 2025
12 checks passed
@nexus49 nexus49 deleted the fix/metadata branch July 31, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants