Skip to content

Feat: add dots support for graphql keys #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

vertex451
Copy link
Member

@vertex451 vertex451 commented Jul 31, 2025

Resolves the issue with labels that contains dots in names like http.bin.
GraphQL doesn't support bare identifiers, so instead of:

labels: {
    keyWithNoDot: "value",
}

we use this:

labels: [
	{key: "key.with.dots", value: "value"},
]

Changes

  1. Added dots support in keys for:
  • labels
  • annotations
  • nodeSelector
  • matchLabel
  1. Refactored schema handleObjectFieldSpecType method due to increased complexity. I took out checks into a natural named functions for a better readability.
  2. Added integration test that creates a deployment with all 4 fields with dots and then retrieves it.
  3. Docs.
Screenshot 2025-07-31 at 13 58 10

@vertex451 vertex451 marked this pull request as ready for review August 4, 2025 11:35
@vertex451 vertex451 requested a review from a team as a code owner August 4, 2025 11:35
@vertex451 vertex451 requested review from nexus49 and pteich August 4, 2025 11:35
@vertex451 vertex451 self-assigned this Aug 4, 2025
@vertex451 vertex451 added this to the 2025.Q3 milestone Aug 4, 2025
@vertex451 vertex451 changed the title labels wip Feat: add dots support for graphql keys Aug 4, 2025
@aaronschweig
Copy link
Member

succeded by #296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants