Skip to content

Add support for feed-forward multi-track video requests. #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Add support for feed-forward multi-track video requests. #129

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0428ac5
Add support for feed-forward multi-track video requests.
jrobble May 15, 2025
6745092
Refactor "multi track" to "all tracks".
jrobble May 15, 2025
82b4f93
Remove GetDetections(const MPFAllVideoTracksJob &job).
jrobble Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions detection/api/include/MPFDetectionComponent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,46 @@ namespace MPF { namespace COMPONENT {
};


struct MPFAllVideoTracksJob : MPFJob {
const int start_frame;
const int stop_frame;
const bool has_feed_forward_tracks;
const std::vector<MPFVideoTrack> feed_forward_tracks;

MPFAllVideoTracksJob(std::string job_name,
std::string data_uri,
int start_frame,
int stop_frame,
Properties job_properties,
Properties media_properties)
: MPFJob(std::move(job_name),
std::move(data_uri),
std::move(job_properties),
std::move(media_properties))
, start_frame(start_frame)
, stop_frame(stop_frame)
, has_feed_forward_tracks(false) {
}

MPFAllVideoTracksJob(std::string job_name,
std::string data_uri,
int start_frame,
int stop_frame,
std::vector<MPFVideoTrack> tracks,
Properties job_properties,
Properties media_properties)
: MPFJob(std::move(job_name),
std::move(data_uri),
std::move(job_properties),
std::move(media_properties))
, start_frame(start_frame)
, stop_frame(stop_frame)
, has_feed_forward_tracks(true)
, feed_forward_tracks(std::move(tracks)) {
}
};


struct MPFImageJob : MPFJob {
const bool has_feed_forward_location;
const MPFImageLocation feed_forward_location;
Expand Down Expand Up @@ -205,6 +245,10 @@ namespace MPF { namespace COMPONENT {

virtual std::vector<MPFVideoTrack> GetDetections(const MPFVideoJob &job) = 0;

virtual std::vector<MPFVideoTrack> GetDetections(const MPFAllVideoTracksJob &job) {
throw std::runtime_error{"MPFAllVideoTracksJob is not currently supported."};
}

virtual std::vector<MPFImageLocation> GetDetections(const MPFImageJob &job) = 0;

virtual std::vector<MPFAudioTrack> GetDetections(const MPFAudioJob &job) = 0;
Expand Down