Skip to content

Conversation

@NethmiRodrigo
Copy link
Contributor

This reverts the PR #9 because this tag gets added by the appointment module

@ibacher
Copy link
Member

ibacher commented Mar 4, 2025

I think we want to keep this, no? We should have at least one location tagged as an appointment location.

@ibacher ibacher closed this Mar 4, 2025
@denniskigen
Copy link
Member

denniskigen commented Mar 4, 2025

So the (partial) context behind this revert is that the release deploy job on Bamboo was failing with a bunch of errors, one of which relates to the Appointment Location tag added here:

CleanShot 2025-03-04 at 8  02 32@2x

Here's the full log.

Per Wikum, it appears that the Appointment Location tag is already coming from the Appointments Module on the backend.

Feel free to ignore all the above if you've already spoken to Nethmi about this and there's some additional context I'm missing.

@NethmiRodrigo
Copy link
Contributor Author

NethmiRodrigo commented Mar 4, 2025

I think we want to keep this, no? We should have at least one location tagged as an appointment location.

@ibacher Yeah, the reason I made the revert PR was because I was afraid that by the time the locations are processed, the appointment module might not have created the location tag yet

@ibacher
Copy link
Member

ibacher commented Mar 4, 2025

the appointment module might not have created the location tag yet

Right. That shouldn't be possible to have happen (Iniz runs after the appointments module because it depends on the appointments module).

@NethmiRodrigo NethmiRodrigo deleted the revert-9-feat/add-appointment-location branch April 9, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants