Refactor: improve readability and null safety in SchemaOnlyTuner #5451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out changing functionality - Added null checks and used Objects.requireNonNull to ensure document safety. - Ensured null-safe detachment of Liquibase tables in detachChangeSet(). - Simplified XPath expressions and improved code consistency. - Replaced string comparisons with null-safe equals(). - Enhanced assertion messages for clarity during schema verification. - Updated Javadocs for readability and structure. No changes in functionality or behavior; purely refactoring and style improvements.
Contributor
|
Thank you @ritesh19331 for this. Did you get a chance to review our PR tips page: https://openmrs.atlassian.net/wiki/spaces/docs/pages/25477199/Pull+Request+Tips |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improved readability, added null safety, and enhanced assertion messages in SchemaOnlyTuner.
Changes
Objects.requireNonNullfor document safety.detachChangeSet().equals()for null safety.Notes
No functional or behavioral changes introduced. This is a pure refactoring improvement.
Issue
No ticket required (minor internal refactoring).