Skip to content

TRUNK-4860: Add assertion for validation message in ValidateUtilTest #5539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+18 −0
Open

TRUNK-4860: Add assertion for validation message in ValidateUtilTest #5539

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
68e13a6
TRUNK-4860: Added validation message assertion test for ValidateUtil
Jagdish-Singh-Bisht Nov 30, 2025
37ccd09
Merge branch 'master' into TRUNK-4860
Jagdish-Singh-Bisht Nov 30, 2025
f8c283e
Merge branch 'master' into TRUNK-4860
Jagdish-Singh-Bisht Dec 2, 2025
7eb9850
Merge branch 'master' into TRUNK-4860
Jagdish-Singh-Bisht Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions api/src/test/java/org/openmrs/validator/ValidateUtilTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
*/
package org.openmrs.validator;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertNull;
Expand Down Expand Up @@ -208,4 +209,21 @@ public void validate_shouldReturnThrowExceptionAlongWithAppropriateMessageIfTheO
ValidationException exception = assertThrows(ValidationException.class, () -> ValidateUtil.validate(drug));
assertTrue(exception.getMessage().contains("failed to validate with reason: name: This value exceeds the maximum length of 255 permitted for this field."));
}

//fixed :validating a location
@Test
public void validate_shouldExposeExactValidationMessage() {
// Arrange
Location loc = new Location(); // invalid: name missing
BindException errors = new BindException(loc, "location");

// Act
ValidationException ex = assertThrows(ValidationException.class,
() -> ValidateUtil.validate(loc));

// Assert
assertTrue(ex.getErrors().hasFieldErrors("name"));
assertEquals("error.name", ex.getErrors().getFieldError("name").getCode());
}

}