Skip to content

Conversation

@sudhanshu-raj
Copy link
Contributor

Description of what I changed

This PR focuses on adding JUnit tests for selected HibernateFormDAO methods to validate correct behavior under different conditions.

Test covered on this subtask:

getFields getFields_shouldReturnCorrectFieldsByName

getFieldsByConcept getFieldsByConcept_shouldReturnCorrectFieldsByConcept

getAllFields getAllFields_shouldReturnCorrectFieldsByRetiredStatus

getFormField getFormField_shouldReturnCorrectFormFieldBasedOnParameters

getAllForms getAllForms_shouldReturnCorrectFormsByRetiredStatus

Issue I worked on

see https://issues.openmrs.org/browse/TRUNK-6518

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@sonarqubecloud
Copy link

@sudhanshu-raj
Copy link
Contributor Author

Hey @dkayiwa , any thoughts ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant