Skip to content

TRUNK-4860: Assert validation error code for blank gender in PatientV… #5720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emphor11 wants to merge 2 commits into
base: master
Choose a base branch
from
+9 −0
Open

TRUNK-4860: Assert validation error code for blank gender in PatientV… #5720

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c0c213
TRUNK-4860: Assert validation error code for blank gender in PatientV…
emphor11 Jan 29, 2026
5c293ad
Merge branch 'master' into TRUNK-4860-validator-test-messages
emphor11 Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions api/src/test/java/org/openmrs/validator/PatientValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
import org.springframework.validation.BindException;
import org.springframework.validation.Errors;
import org.springframework.validation.Validator;
import static org.junit.Assert.assertEquals;


/**
* Tests methods on the {@link PatientValidator} class.
Expand Down Expand Up @@ -56,6 +58,8 @@ public void validate_shouldFailValidationIfAPreferredPatientIdentifierIsNotChose
Errors errors = new BindException(pa, "patient");
validator.validate(pa, errors);
assertTrue(errors.hasErrors());
assertTrue(errors.hasGlobalErrors());
assertEquals("error.preferredIdentifier", errors.getGlobalError().getCode());
}

/**
Expand Down Expand Up @@ -117,6 +121,10 @@ public void validate_shouldFailValidationIfGenderIsBlank() {
validator.validate(pa, errors);

assertTrue(errors.hasFieldErrors("gender"));
assertTrue(
errors.getFieldErrors("gender").stream()
.anyMatch(e -> "Person.gender.required".equals(e.getCode()))
);
}

/**
Expand Down Expand Up @@ -194,5 +202,6 @@ public void validate_shouldFailValidationIfFieldLengthsAreNotCorrect() {
validator.validate(patient, errors);

assertTrue(errors.hasFieldErrors("voidReason"));
assertEquals("error.exceededMaxLengthOfField",errors.getFieldError("voidReason").getCode());
}
}
Loading