(feat) O3-5121: Add ability to edit cashpoints

[abertnamanya]

Requirements

• This PR has a title that briefly describes the work done including a conventional commit type prefix and a Jira ticket number if applicable. See existing PR titles for inspiration.
• My work is based on designs, which are linked or shown either in the Jira ticket or the description below.
• My work includes tests or is validated by existing tests.

Summary

Edit/update cashpoints in the billing module

Screenshots

Screen-Recording.5.mp4

Related Issue

https://openmrs.atlassian.net/browse/O3-5121

Other

[NethmiRodrigo]

Thanks @abertnamanya, a few suggestions:

[denniskigen]

Does the backend resource fully support editing cash points? @dkayiwa

[dkayiwa]

@denniskigen no it does not.

[denniskigen]

So we'd need to fix that as a pre-requisite for any work on the frontend, right?

[denniskigen]

Actually, it looks like the save functionality exists in the base class here https://github.com/openmrs/openmrs-module-billing/blob/main/omod/src/main/java/org/openmrs/module/billing/web/base/resource/BaseRestMetadataResource.java#L61, so this should be viable. I'd recommend dropping the UUID field entirely from the form and also verifying that the ModalHeader changes based on the context in which the form is used. From the video, it says "Add cash point" for both the create and edit flows.

[NethmiRodrigo]

I'd recommend dropping the UUID field entirely from the form

@denniskigen I think its okay to leave this as is because cash points are mainly meant to be an Iniz config like so - https://github.com/openmrs/openmrs-content-referenceapplication-demo/blob/main/configuration/backend_configuration/cashpoints/cashPoints.csv

The current implementation allows editing cash points through the UI, but these changes:

• Only update the database - not the original configuration files
• Create configuration drift between CSV files and database state
• Will be lost during system rebuilds or deployments
• Don't propagate to other environments

Maybe we could add a clear warning indicating that changes made to the cash points configuration are ephemeral and that the canonical place to make changes is in the demo content package.

Any thoughts, @ibacher?

[denniskigen]

Suggested change

	method: 'POST',
	method: 'PUT',

PUT is the canonical HTTP request method for updates.

[abertnamanya]

Yeah, it should be a PUT, but the endpoint does not seem to accept the request

[denniskigen]

Yeah, that sounds like a bug. The controller in the backend might be misparsing main resource URLs. Could you have a look when you get some time, @wikumChamith?

Let's keep it as a POST for now, @abertnamanya.

[denniskigen]

So, the code LGTM. What's holding this up is the potential config drift issue I spoke about here. Still eager to hear the thoughts of @dkayiwa @wikumChamith @ibacher on how we should handle it.