Skip to content

Conversation

@IamMujuziMoses
Copy link

@IamMujuziMoses IamMujuziMoses commented Apr 29, 2025

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. Ensure your PR title includes a conventional commit label (such as feat, fix, or chore, among others). See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

Screenshots

Screenshot 2025-04-28 at 23 56 42

Screen.Recording.2025-04-29.at.20.47.31.mov

Related Issue

https://issues.openmrs.org/browse/O3-3890

@IamMujuziMoses
Copy link
Author

@chibongho @denniskigen could you please review this PR, your feedback will be appreciated

@IamMujuziMoses
Copy link
Author

Tutorials is not formatted because it comes from esm-user-onboarding I am thinking that, a new ticket is required from that repository

@chibongho
Copy link
Contributor

Shouldn't we use the <Menu> Carbon component instead of fixing the custom menu we have? It's what the ticket is specifying.

@IamMujuziMoses
Copy link
Author

@chibongho Certainly! I understand your preference for using Carbon menu component over custom CSS for easier maintenance. I'll make the necessary adjustments to implement the changes using Carbon Menu.

@chibongho
Copy link
Contributor

Yeah, it's preferable that we don't write / maintain our own custom component That said, I don't know why we made this in the first place. I just wanted to ask if you know the reason, and if the reason is still valid.

@IamMujuziMoses
Copy link
Author

@chibongho I have no idea maybe @denniskigen

@IamMujuziMoses
Copy link
Author

Screen.Recording.2025-05-09.at.18.13.20.mov

@chibongho @denniskigen, I need some help here, I managed to use the Carbon menu component instead of custom CSS but am kind of new to tsx and positioning is proving to be tricky, any pointers on how to position it in the right place, thnx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants