(fix) O3-4562: Fix extension configuration schema machinery #1502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the extension configuration schema concept so that: 1. defineExtensionConfigSchema() correctly registers a config schema associated with an extension by setting the moduleLoaded flag 2. When an extension has its own config schema, it is used exclusively instead of being merged with the module schema Changes: - Added extensionHasOwnConfigSchema() function to check if an extension has its own config schema defined - Fixed defineExtensionConfigSchema() to set moduleLoaded flag - Updated useConfig hook to use extension-specific schemas exclusively when they exist, falling back to merged configs otherwise - Updated mock files for testing compatibility Testing: All 95 existing tests pass. Extension config schemas now work as designed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
This PR has a title that briefly describes the work done including the ticket number. Ensure your PR title includes a conventional commit label (such as
feat,fix, orchore, among others). See existing PR titles for inspiration.If applicable
My work includes tests or is validated by existing tests.
I have updated the esm-framework mock to reflect any API changes I have made.
Summary
This PR fixes the extension configuration schema machinery so that extensions can properly define and use their own configuration schemas independent of module schemas.
Problems Solved:
defineExtensionConfigSchema()wasn't properly registering extension schemas (missingmoduleLoadedflag)useConfighook was always merging module config with extension config, even when extension had its own schemaChanges:
extensionHasOwnConfigSchema()function to check if an extension has its own config schemadefineExtensionConfigSchema()to set themoduleLoadedflaguseConfighook to use extension-specific schemas exclusively when they existmock.ts,mock-jest.ts) for testing compatibilityBehavior:
When an extension defines its own config schema using
defineExtensionConfigSchema(), theuseConfighook now returns only the extension's config (not merged with module config). When no extension schema exists, it falls back to merging module + extension configs.Related Issue
https://openmrs.atlassian.net/browse/O3-4562
Other
All 95 existing tests pass. Extension config tests verify the correct exclusive schema usage. No breaking changes to existing functionality.