(fix) O3-5247 Hamburger Menu Close Button Not Working #1514
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
feat,fix, orchore, among others). See existing PR titles for inspiration.If applicable
Summary
This PR fixes an issue where the tab navbar would immediately reopen after being closed via the hamburger button.
Changes
e.stopPropagation()toonMouseDownandonTouchStartevents on theHeaderMenuButton(hamburger icon).Reasoning
The hamburger button click was propagating to a global "click outside" listener (likely
useOnClickOutsideor similar), causing a race condition where the menu would toggle state twice (close -> open) or interfere with the intended toggle action. Stopping propagation ensures the button click is handled in isolation.Screenshots
before:
issue-hamburger.mp4
after:
fix-hamburger.mp4
Related Issue
https://openmrs.atlassian.net/browse/O3-5247