Skip to content

(fix) O3-3875: JSON editor in the form builder does not show an error indicator #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RajPrakash681 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

(fix) O3-3875: JSON editor in the form builder does not show an error indicator #1085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b8ce15
(fix) O3-3875: remove CDN dependency from schema editor ace configura…
RajPrakash681 Feb 17, 2026
dc94a88
fix readability and type safety issues
RajPrakash681 Feb 20, 2026
7ecfe42
Merge branch 'main' into fix-schema-editor-error-indicators
RajPrakash681 Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 14 additions & 31 deletions src/components/form-editor/form-editor.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ interface ErrorProps {
}

interface TranslationFnProps {
t: TFunction;
readonly t: TFunction;
}

interface MarkerProps extends IMarker {
Expand Down Expand Up @@ -223,15 +223,13 @@ const FormEditorContent: React.FC<TranslationFnProps> = ({ t }) => {

const renderSchemaChanges = useCallback(() => {
resetErrorMessage();
{
try {
const parsedJson: Schema = JSON.parse(stringifiedSchema);
updateSchema(parsedJson);
setStringifiedSchema(JSON.stringify(parsedJson, null, 2));
} catch (e) {
if (e instanceof Error) {
setInvalidJsonErrorMessage(e.message);
}
try {
const parsedJson: Schema = JSON.parse(stringifiedSchema);
updateSchema(parsedJson);
setStringifiedSchema(JSON.stringify(parsedJson, null, 2));
} catch (e) {
if (e instanceof Error) {
setInvalidJsonErrorMessage(e.message);
}
}
}, [stringifiedSchema, updateSchema, resetErrorMessage]);
Expand All @@ -258,25 +256,11 @@ const FormEditorContent: React.FC<TranslationFnProps> = ({ t }) => {
}
}, [blockRenderingWithErrors, errors.length, renderSchemaChanges, selectedLanguageCode]);

const handleSchemaImport = (event: React.ChangeEvent<HTMLInputElement>) => {
const handleSchemaImport = async (event: React.ChangeEvent<HTMLInputElement>) => {
const file = event.target.files[0];
const reader = new FileReader();

reader.onload = (e) => {
const result = e.target?.result;
if (typeof result === 'string') {
const fileContent: string = result;
const parsedJson: Schema = JSON.parse(fileContent);
setSchema(parsedJson);
} else if (result instanceof ArrayBuffer) {
const decoder = new TextDecoder();
const fileContent: string = decoder.decode(result);
const parsedJson: Schema = JSON.parse(fileContent);
setSchema(parsedJson);
}
};

reader.readAsText(file);
const fileContent = await file.text();
const parsedJson: Schema = JSON.parse(fileContent);
setSchema(parsedJson);
};

const downloadableSchema = useMemo(
Expand Down Expand Up @@ -316,7 +300,7 @@ const FormEditorContent: React.FC<TranslationFnProps> = ({ t }) => {
<div className={styles.heading}>
<span className={styles.tabHeading}>{t('schemaEditor', 'Schema editor')}</span>
<div className={styles.topBtns}>
{!schema ? (
{!schema && (
<FileUploader
onChange={handleSchemaImport}
labelTitle=""
Expand All @@ -331,7 +315,7 @@ const FormEditorContent: React.FC<TranslationFnProps> = ({ t }) => {
iconDescription={t('importSchema', 'Import schema')}
name="form-import"
/>
) : null}
)}
{isNewSchema && !schema ? (
<Button kind="ghost" onClick={inputDummySchema}>
{t('inputDummySchema', 'Input dummy schema')}
Expand Down Expand Up @@ -397,7 +381,6 @@ const FormEditorContent: React.FC<TranslationFnProps> = ({ t }) => {
<div className={styles.editorContainer}>
<SchemaEditor
errors={errors}
isLoading={isLoadingFormOrSchema}
onSchemaChange={handleSchemaChange}
setErrors={setErrors}
setValidationOn={setValidationOn}
Expand Down
Loading