(feat) O3-3980: Synchronize Highlighting Between Interactive Builder and Schema Editor#379
Draft
Twiineenock wants to merge 2 commits intoopenmrs:mainfrom
Draft
(feat) O3-3980: Synchronize Highlighting Between Interactive Builder and Schema Editor#379Twiineenock wants to merge 2 commits intoopenmrs:mainfrom
Twiineenock wants to merge 2 commits intoopenmrs:mainfrom
Conversation
NethmiRodrigo
requested changes
Jan 22, 2025
Collaborator
NethmiRodrigo
left a comment
There was a problem hiding this comment.
@Twiineenock thank you for picking this up. A couple of things,
- Please update the PR description
- A question in the interactive editor gets the highlighted styles only if you select a question on the schema editor, it'll be better if it gets highlighted when you click on the question. This is important because even when you select another question on the interactive builder, the previous question stays highlighted.
- The app breaks when you go back from a form
Screen.Recording.2025-01-22.at.2.46.20.PM.mov
Contributor
Author
Thanks @NethmiRodrigo for catching those, I will be sure to fix them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ma Editor
Requirements
Summary
The question selection is not synchronized between the interactive builder and schema editor.
When a question is highlighted in either the interactive builder or schema editor, it should automatically reflect and be highlighted in the other interface.
Screenshots
Screancasts
Clicking in the Schema editor
h1.webm
Clicking in the Interactive builder
h2.webm
Related Issue
https://openmrs.atlassian.net/browse/O3-3980
Other