(refactor) Add selectable orders section in testOrder question#381
Draft
CynthiaKamau wants to merge 1 commit intomainfrom
Draft
(refactor) Add selectable orders section in testOrder question#381CynthiaKamau wants to merge 1 commit intomainfrom
CynthiaKamau wants to merge 1 commit intomainfrom
Conversation
Contributor
|
Size Change: +377 B (+0.01%) Total Size: 3.9 MB ℹ️ View Unchanged
|
NethmiRodrigo
requested changes
Jan 24, 2025
Collaborator
NethmiRodrigo
left a comment
NethmiRodrigo
left a comment
There was a problem hiding this comment.
Thanks @CynthiaKamau! A couple of nits and a bug I came across when editing the selected orders where the default selected concept would be set to the one that you removed even after saving the edit:
Screen.Recording.2025-01-24.at.10.51.40.PM.mov
Comment on lines
+206
to
+207
| const updatedDatePickerType = getDatePickerType(concept); | ||
| if (updatedDatePickerType) setDatePickerType(updatedDatePickerType); |
Collaborator
There was a problem hiding this comment.
The datepicker type is unnecessary
Suggested change
| const updatedDatePickerType = getDatePickerType(concept); | |
| if (updatedDatePickerType) setDatePickerType(updatedDatePickerType); |
Member
There was a problem hiding this comment.
Also, prefer wrapping the if block in braces.
| const handleAnsConceptChange = (event: React.ChangeEvent<HTMLInputElement>) => | ||
| setConceptAnsToLookup(event.target.value); | ||
|
|
||
| const handleOrdersChange = (event: React.ChangeEvent<HTMLInputElement>) => setConceptToLookup(event.target.value); |
Collaborator
There was a problem hiding this comment.
Nit: empty line between the two functions
Suggested change
| const handleOrdersChange = (event: React.ChangeEvent<HTMLInputElement>) => setConceptToLookup(event.target.value); | |
| const handleOrdersChange = (event: React.ChangeEvent<HTMLInputElement>) => setConceptToLookup(event.target.value); | |
Comment on lines
+1124
to
+1132
| {selectedOrders.length ? ( | ||
| <div> | ||
| {selectedOrders.map((answer) => ( | ||
| <Tag className={styles.tag} key={answer.concept} type={'blue'}> | ||
| {answer.label} | ||
| </Tag> | ||
| ))} | ||
| </div> | ||
| ) : null} |
Collaborator
There was a problem hiding this comment.
Its better if we can have a way to remove selected ones, similar to how you've done when editing.
Comment on lines
+227
to
+230
| const datePickerType = getDatePickerType(concept); | ||
| if (datePickerType) { | ||
| setDatePickerType(datePickerType); | ||
| } |
Collaborator
There was a problem hiding this comment.
Suggested change
| const datePickerType = getDatePickerType(concept); | |
| if (datePickerType) { | |
| setDatePickerType(datePickerType); | |
| } |
|
|
||
| {questionToEdit.type === 'testOrder' && ( | ||
| <> | ||
| <Search |
Collaborator
There was a problem hiding this comment.
You've forgotten to add the form label here
Collaborator
|
Hey @CynthiaKamau! I did a major refactor to the question modal (that makes it much easier to add new features like this one) and unfortunately this is one of the PRs that gets affected by it. Rather than clearing the conflicts, I do think it'll be easier to just make a new PR (sorry about that!). That said, I did try to include support for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
(refactor) Add selectable orders section in testOrder question
Screenshots
Screen.Recording.2025-01-24.at.19.38.40.mov
Related Issue
Other