(fix) Additional concept answers field disappears when selecting a concept#394
Merged
denniskigen merged 3 commits intomainfrom Feb 17, 2025
Merged
(fix) Additional concept answers field disappears when selecting a concept#394denniskigen merged 3 commits intomainfrom
denniskigen merged 3 commits intomainfrom
Conversation
Contributor
|
Size Change: +74 B (0%) Total Size: 3.89 MB ℹ️ View Unchanged
|
ibacher
reviewed
Feb 14, 2025
Member
ibacher
left a comment
There was a problem hiding this comment.
Basically LGTM. Couple of small things.
...ive-builder/modals/question/question-form/common/concept-search/concept-search.component.tsx
Outdated
Show resolved
Hide resolved
...ive-builder/modals/question/question-form/common/concept-search/concept-search.component.tsx
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR fixes a bug where when you attempt to select an additional concept answer, the entire search field to search for an additional concept would disappear. This was because, the concept-search would update the context provider's
conceptobject, which was meant to save the main concept that the user selects for the entire questionScreenshots
Before fix:
Screen.Recording.2025-02-14.at.4.00.52.PM.mov
After fix:
Screen.Recording.2025-02-14.at.4.01.48.PM.mov
Related Issue
https://issues.openmrs.org/browse/O3-4448
Other