(test) O3-3926 Improve inline-date-adapter test coverage.#674
Open
suubi-joshua wants to merge 2 commits intoopenmrs:mainfrom
Open
(test) O3-3926 Improve inline-date-adapter test coverage.#674suubi-joshua wants to merge 2 commits intoopenmrs:mainfrom
suubi-joshua wants to merge 2 commits intoopenmrs:mainfrom
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Ensure inline-date-adapter.ts is robust against edge cases in OpenMRS form engine.
Test Scenarios Implemented
Overwrite target field's obs date prop value
Tests submission updates with Date objects and strings.
Edit previously associated date in edit mode
Optimization test: Only updates obsDatetime when value actually changes
Commit side-effects when target field has value or submission
Tests submission creation with current or initial values
New validation: Prevents submission when target field has NO value
Ensures no orphaned dates without observation data
Extract initial value from target field's obs
Tests retrieval from target field's observation object
Handles missing data and edge cases
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-3926
Other