O3-5332: Add initial Growth Chart app#2944
O3-5332: Add initial Growth Chart app#2944dilankavishka wants to merge 4 commits intoopenmrs:mainfrom
Conversation
|
@anjula-sack @denniskigen Could you review this please? |
| @@ -0,0 +1,117 @@ | |||
| # @openmrs/esm-patient-growth-chart-app | |||
There was a problem hiding this comment.
Can you update this with more details like a small description of growth chart, scope, implementation plan and current status? @dilankavishka
| } | ||
| } | ||
| ] | ||
| } No newline at end of file |
There was a problem hiding this comment.
Missing end of line here
| "@openmrs/esm-form-engine-lib": "next", | ||
| "lodash-es": "^4.17.21", | ||
| "react-error-boundary": "^4.0.13" | ||
| "lodash.findlast": "^4.6.0", |
There was a problem hiding this comment.
Why form engine's package.json is updated? @dilankavishka
|
Thank you kicking this off @dilankavishka! I hope this doesn’t sound harsh, but a couple of things (that applies to your other PRs as well):
|
|
Thank you so much for the feedback @NethmiRodrigo ! I understand the concerns about the PR. I’ll adjust my approach and combine the related changes into a single PR going forward. would it be okay if I close other two PRs and combine their changes into this PR, and then continue all future work on this branch to deliver the complete functionality in a single PR? |
Requirements
Summary
Created the Growth Chart App
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-5332
Other