Skip to content

(feat) O3-4815: Filter appointments table by service and status dropdown fields#1987

Closed
EDSONZ-WASSWA wants to merge 5 commits intoopenmrs:mainfrom
EDSONZ-WASSWA:O3-4815-appointments-filter-by-service-and-filter-by-status-dropdowns-in-appointments-table
Closed

(feat) O3-4815: Filter appointments table by service and status dropdown fields#1987
EDSONZ-WASSWA wants to merge 5 commits intoopenmrs:mainfrom
EDSONZ-WASSWA:O3-4815-appointments-filter-by-service-and-filter-by-status-dropdowns-in-appointments-table

Conversation

@EDSONZ-WASSWA
Copy link
Contributor

@EDSONZ-WASSWA EDSONZ-WASSWA commented Sep 23, 2025

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work is based on designs, which are linked or shown either in the Jira ticket or the description below.
  • My work includes tests or is validated by existing tests.

Summary

I removed all other filters that appeared on the Appointments page and put them in the Appointments table as the ticket required.

Screenshots

Before

filterrrrrrrr--scrnsht

After

screen11111111112 00_00_00-00_00_30

Related Issue

https://issues.openmrs.org/browse/O3-4815

Other

@denniskigen have a look at this PR

@denniskigen denniskigen changed the title O3-4815 Appointments: Filter by service and filter by status dropdown… (feat) O3-4815: Filter appointments table by service and status dropdown fields Sep 24, 2025
…ilter-by-status-dropdowns-in-appointments-table
@brandones brandones self-requested a review November 3, 2025 14:32
Copy link
Contributor

@brandones brandones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest you redo this completely.

  1. Why are you using the content switcher? Just display a single table that filters its content.
  2. The service filter dropdown should go in the top-right corner, where it was.
  3. The service filter should continue to use the store.
  4. The status filter should go in a single line with the search filter and download button. Refer to the service queues table for design if you're not sure what I mean.

…ilter-by-status-dropdowns-in-appointments-table
@EDSONZ-WASSWA
Copy link
Contributor Author

Similar changes are implemented on this PR #2151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants