Conversation
gitcliff
changed the title
Contributor
|
Size Change: -587 kB (-6.88%) ✅ Total Size: 7.95 MB
ℹ️ View Unchanged
|
denniskigen
changed the title
ibacher
reviewed
Nov 25, 2025
packages/esm-appointments-app/src/calendar/header/calendar-header.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-appointments-app/src/calendar/header/calendar-header.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-appointments-app/src/calendar/monthly/days-of-week.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-appointments-app/src/calendar/monthly/days-of-week.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-appointments-app/src/calendar/monthly/monthly-header.component.tsx
Outdated
Show resolved
Hide resolved
gitcliff
force-pushed
the
03-5089
branch
2 times, most recently
from
02b2afc to
eeea827
Compare
ibacher
reviewed
Dec 15, 2025
packages/esm-appointments-app/src/workload/monthly-view-workload/monthly-view.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-appointments-app/src/workload/monthly-view-workload/monthly-view.component.tsx
Outdated
Show resolved
Hide resolved
| const monthViewDate = dateToDisplay === '' ? selectedDate : dateToDisplay; | ||
| const daysInWeeks = daysInWeek.map((day) => t(day)); | ||
| const todayDate = toCalendarDate(today(getLocalTimeZone())); | ||
| const todayShort = new Intl.DateTimeFormat(getLocale(), { weekday: 'short' }) |
Member
There was a problem hiding this comment.
This is sort of obviously broken because you'll only get the correct strings if the locale is English right?
Contributor
Author
There was a problem hiding this comment.
This is sort of obviously broken because you'll only get the correct strings if the locale is English right?
i have tested it on spanish , french locales and it works . On other locals like Romania , Portuguese it fails
Member
There was a problem hiding this comment.
Sorry, I was thinking about the daysInWeeks thing below because that array is English names...
Contributor
Author
There was a problem hiding this comment.
Sorry, I was thinking about the
daysInWeeksthing below because that array is English names...
yeah it's clear @ibacher , have updated it to switch to the user's locale
packages/esm-appointments-app/src/workload/monthly-view-workload/monthly-view.component.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
thanks @ibacher, i would appreciate another round of review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Rework the appointments calendar display to use
@internationalized/daterather thandayjsto determine the current month and calculate the number of days in the month, etc. The correct calendar can be determined by calling the esm-framework functiongetDefaultCalendar()which looks up the default calendar associated with the user’s current locale and returns that.Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-5089?isEligibleForUserSurvey=true
Other