(feat) O3-5265 implemented delete bed feature in Bed Management

[sourav-jyoti]

Requirements

• This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
• My work is based on designs, which are linked or shown either in the Jira ticket or the description below.
• My work includes tests or is validated by existing tests.

Summary

There was no delete bed feature pn frontend though an api was available for it -- (delete) /bed/[uuid]
this pr implements the delete feature on ui

Screenshots

Before

After

Screencast.From.2025-12-19.12-43-15.mp4

Related Issue

https://openmrs.atlassian.net/issues?filter=-1&selectedIssue=O3-5265

[gitcliff]

thanks @sourav-jyoti for the work on this , have you seen the OpenMRS CI / build (pull_request) failure . its coming from test leakage and overly strict expectations, not by a bug in the component. mockMutateBeds is a shared Jest mock that is reused across multiple tests, and its call history is not reset between renders/tests. Because the DeleteBed component is rendered many times in the same test file—and React may re-render during async state updates—the mock accumulates calls. This makes assertions like toHaveBeenCalledTimes(1) fail even though the component logic correctly calls mutateBeds once per successful deletion.

[sourav-jyoti]

Thanks @gitcliff I've identified and fixed the issues:

The mockMutateBeds is a shared Jest mock, and despite clearMocks: true in global jest config, it seems call history was persisting across tests.

Changes:

1. Changed toHaveBeenCalledTimes(1) to toHaveBeenCalled() to handle React re-renders during async updates

2. Split "closes the modal regardless of whether the deletion succeeds or fails" into two separate tests to avoid mock accumulation from double-rendering

3. For "does not call mutateBeds when deletion fails" (L163) - I tried beforeEach(() => jest.resetAllMocks()) and afterEach(() => jest.clearAllMocks()) but neither worked. The only solution that worked was creating a fresh mock instance:

   Question:

   Is using a local mock instance the right approach here, or is there a better pattern I should follow?

[sourav-jyoti]

@denniskigen could you pls review this pr

[UjjawalPrabhat]

@sourav-jyoti have you confirmed with @VeronicaMuthee if we even want the delete functionality? Also if we do, consider adding them in an overflow menu. Would look much cleaner

[sourav-jyoti]

@VeronicaMuthee could you please take a look at the functionality

[VeronicaMuthee]

Hey @sourav-jyoti, we need to clarify with PIH folks. And if that's the case, overflow menu makes sense as suggested by @UjjawalPrabhat. cc: @chibongho

[sourav-jyoti]

Hey @sourav-jyoti, we need to clarify with PIH folks. And if that's the case, overflow menu makes sense as suggested by @UjjawalPrabhat. cc: @chibongho

Ok after the confirmation of the functionality i will update it

[sourav-jyoti]

@denniskigen should i use < stack > here similar to https://github.com/openmrs/openmrs-esm-billing-app/pull/629/changes#diff-cfde1cff3804d2ed593ce6a901b90ae254aa57831151dce56388197c83a487a4R60

[denniskigen]

The Stack is used for consistent vertical spacing when we have more than one nested block-level element. In this case because we only have a TextInput as the sole nested element, we shouldn't need to use a Stack here.

[VeronicaMuthee]

Hey @sourav-jyoti, we need to clarify with PIH folks. And if that's the case, overflow menu makes sense as suggested by @UjjawalPrabhat. cc: @chibongho

@sourav-jyoti, here is the feedback from PIH (Fiona): "If it can be permissioned so not everyone can delete beds then it's a good feature to have."

[sourav-jyoti]

@sourav-jyoti, here is the feedback from PIH (Fiona): "If it can be permissioned so not everyone can delete beds then it's a good feature to have."

awesome ! thnks for the follow up
@VeronicaMuthee
this is the updated guide for making components configurable right https://o3-docs.openmrs.org/docs/configure-o3 ?