(fix) : prevent errors when queue entries have no priority configured#2285
Open
donaldkibet wants to merge 1 commit intomainfrom
Open
(fix) : prevent errors when queue entries have no priority configured#2285donaldkibet wants to merge 1 commit intomainfrom
donaldkibet wants to merge 1 commit intomainfrom
Conversation
Contributor
|
Size Change: +35 B (0%) Total Size: 8.18 MB ℹ️ View Unchanged
|
ibacher
requested changes
Feb 27, 2026
Member
ibacher
left a comment
ibacher
left a comment
There was a problem hiding this comment.
@donaldkibet Thanks, but I don't think this is mergeable in this state. We still need to try to prevent users from creating queue entries without priorities in the RefApp and not just KeHMIS. If the allowed laxness can be hidden behind configuration, I suppose this is acceptable, but as-is, this will break any other implementation.
| )} | ||
| type={priorityConfig?.color !== 'orange' ? priorityConfig?.color : null}> | ||
| {priority.display} | ||
| {priority?.display} |
Member
There was a problem hiding this comment.
Isn't this just rendering an empty tag? It seems like we could just guard against rendering this at all if there's no priority uuid?
| formState.selectedQueue == queueEntry.queue.uuid && | ||
| formState.selectedStatus == queueEntry.status.uuid && | ||
| formState.selectedPriority == queueEntry.priority.uuid, | ||
| formState.selectedPriority == queueEntry?.priority?.uuid, |
Member
There was a problem hiding this comment.
I don't love this is a general implementation. Yes, this fixes the issue for KeHMIS, but not for anyone else. I can't merge this in if users can just create entries without setting priorities, which is what this blocks.
Contributor
|
@donaldkibet we are doing a custom build for queues. I think this might not be necessary here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR prevents undefined error when the queue priority hasn't been set. This happens in our distro(KeHMIS) since priority is evaluated using TEWS calculation from triage.
Screenshots
Related Issue
Other