fix: average wait time card never fetches data#2320
Open
shubhangiisinghh wants to merge 2 commits intoopenmrs:mainfrom
Open
fix: average wait time card never fetches data#2320shubhangiisinghh wants to merge 2 commits intoopenmrs:mainfrom
shubhangiisinghh wants to merge 2 commits intoopenmrs:mainfrom
Conversation
useAverageWaitTime was called with an empty string for statusUuid. The hook skips the API call when statusUuid is falsy, so the card always showed '--'. Passing defaultStatusConceptUuid from config instead, same as waiting-patients.extension.tsx already does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description:
The average wait time card was always showing '--' and never loading actual data.
Turns out useAverageWaitTime was being called with an empty string as the statusUuid. The hook skips the API call if either serviceUuid or statusUuid is falsy — so the request was never made.
The fix is just passing defaultStatusConceptUuid from config, which is what waiting-patients.extension.tsx already does right next door.