fix: add batch actions translations (O3-5409)#2325
Open
sachin-mahato25 wants to merge 1 commit intoopenmrs:mainfrom
Open
fix: add batch actions translations (O3-5409)#2325sachin-mahato25 wants to merge 1 commit intoopenmrs:mainfrom
sachin-mahato25 wants to merge 1 commit intoopenmrs:mainfrom
Conversation
omeriinnocent
left a comment
omeriinnocent
left a comment
There was a problem hiding this comment.
@sachin-mahato25 ,you can remove the todo comment and check your title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR adds translation support for Carbon's table batch actions in the appointments table component.
Previously, labels such as "Cancel", "item selected", and "items selected" were not translated. This update introduces a
translateWithIdfunction to provide translations for these batch action labels.Screenshots
Not applicable (no UI design changes).
Related Issue
https://openmrs.atlassian.net/browse/O3-5409
Other
Verified that batch action labels display correctly when selecting appointments in the table.
Note: I noticed this issue was assigned, but I did not see an open PR, so I attempted to work on it. Please let me know if any changes are required.