Skip to content

Conversation

@wikumChamith
Copy link
Member

@wikumChamith wikumChamith commented Feb 19, 2025

Description of what I changed

In the openmrs-content-referenceapplication-demo content package, the addressConfiguration.xml file has been renamed to addressConfiguration-core_demo.xml, causing an error when running the application:

`ERROR - AddressConfigurationLoader.loadAddressConfiguration(66) |2025-02-19T15:10:04,762| Address hierarchy configuration file appears invalid, skipping the loading process

This update resolves the issue by updating ADDR_CONFIG_FILE_NAME to match the new file name.

see https://openmrs.atlassian.net/browse/ADDR-138

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@ibacher
Copy link
Member

ibacher commented Feb 19, 2025

Other way around: we should rename the file in the content package if it's required to be named this way. Now that we actually have the content packages, we should be able to remove those suffixes—which were only there to indicate where they would go once we had content packages.

@wikumChamith
Copy link
Member Author

Other way around: we should rename the file in the content package if it's required to be named this way. Now that we actually have the content packages, we should be able to remove those suffixes—which were only there to indicate where they would go once we had content packages.

@ibacher I created a PR for that: openmrs/openmrs-content-referenceapplication-demo#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants