ADDR-139: Fix random test failures on Amazon Corretto images

[Ruhanga]

Description of what I changed

Issue I worked on

Followup PR to fix random test failures on Amazon Corretto images

see https://openmrs.atlassian.net/browse/ADDR-139

Checklist: I completed these to help reviewers :)

• My IDE is configured to follow the code style of this project.

• I have added tests to cover my changes. (If you refactored
  existing code that was well tested you do not have to add tests)

• I ran mvn clean package right before creating this pull request and
  added all formatting changes to my commit.

• All new and existing tests passed.

• My pull request is based on the latest changes of the master branch.

[dkayiwa]

Is there a way i can reproduce this failure locally?

[Ruhanga]

You could run a local build with the command below:

docker run   -v m2-repo:/root/.m2/repository   -v "${PWD}:/module"   --rm   -w="/module"   maven:3.9.9-amazoncorretto-21   bash -c "mvn clean package"

The behaviour is easily reproducible with maven:3.9.9-amazoncorretto-11.

[dkayiwa]

Can you share the clear and detailed instructions of reproducing that locally?

[Ruhanga]

@dkayiwa, the following are the commands to 1.) clone, 2.) checkout the downloaded repo and 3.) finally build the project given docker is installed on your computer... :-)

git clone https://github.com/openmrs/openmrs-module-addresshierarchy
cd openmrs-module-addresshierarchy
docker run   -v m2-repo:/root/.m2/repository   -v "${PWD}:/module"   --rm   -w="/module"   maven:3.9.9-amazoncorretto-21   bash -c "mvn clean package"

To build with Java 11 flavour:

docker run   -v m2-repo:/root/.m2/repository   -v "${PWD}:/module"   --rm   -w="/module"   maven:3.9.9-amazoncorretto-11   bash -c "mvn clean package"

[Ruhanga]

Hi @dkayiwa, could we merge this?

[dkayiwa]

Before merging this in, can you point me to any existing CI build failures?

[Ruhanga]

For example this previous build.