Gate release on build, matching Bamboo stage order#138
Open
Conversation
In Bamboo, Release was stage 3 after Build (stage 1). This adds needs: build to the release job so tests must pass before releasing. Also reverts the build job's 'if: push' condition since build now needs to run on workflow_dispatch too as a prerequisite for release. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Bamboo, Release was stage 3, only running after Build (stage 1) passed. Currently the release job runs independently, so a release could be triggered even if the code doesn't compile.
This adds
needs: buildto the release job. Onworkflow_dispatch, build runs first to verify tests pass, then release proceeds.Note: This reverts the
if: github.event_name == 'push'condition on the build job from PR #135, since build now needs to run on dispatch too as a prerequisite for release.