Added WebUtil.escapeHTML function to ProviderListItem#157
Merged
isears merged 2 commits intoopenmrs:masterfrom May 11, 2021
Merged
Added WebUtil.escapeHTML function to ProviderListItem#157isears merged 2 commits intoopenmrs:masterfrom
isears merged 2 commits intoopenmrs:masterfrom
Conversation
Solved Compatibality issues
isears
requested changes
Apr 11, 2021
Member
isears
left a comment
isears
left a comment
There was a problem hiding this comment.
Ok, I remember this now.
In general, I definitely prefer this server-side approach to patching. The reason #152 got merged in, however, is because it patched EMPT-46 as well as EMPT-64, even if the JS-based patch was less desirable.
@Parth59 if you can include a server-side patch for EMPT-46 in this PR, I'll merge it in.
Contributor
beautiful |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had raised #141 for the following. After which @isears requested to modify the server-side code instead of the JS files. So I tried solving EMPT64 with changes in the following server File:- omod/src/main/java/org/openmrs/web/dwr/ProviderListItem.java. Had to revert the changes of the following PR #152 to make it error free.
Steps to reproduce can be found here.
https://docs.google.com/document/d/1GJNMRlGTRV45St6WSjnD_FjW84aoNxY9HzGbpwoBrro/edit?usp=sharing
Link to ticket:
https://issues.openmrs.org/browse/RA-1865