Use SLF4J logging for exception handling in WebComponentRegistrar#228
Open
aadvik93 wants to merge 6 commits intoopenmrs:masterfrom
Open
Use SLF4J logging for exception handling in WebComponentRegistrar#228aadvik93 wants to merge 6 commits intoopenmrs:masterfrom
aadvik93 wants to merge 6 commits intoopenmrs:masterfrom
Conversation
Co-authored-by: suubi-joshua <78343336+suubi-joshua@users.noreply.github.com>
Co-authored-by: suubi-joshua <78343336+suubi-joshua@users.noreply.github.com>
Co-authored-by: suubi-joshua <78343336+suubi-joshua@users.noreply.github.com>
Co-authored-by: suubi-joshua <78343336+suubi-joshua@users.noreply.github.com>
Author
|
Thank you for the review. |
|
Hi @aadvik93 , Thank you for the PR! Could you please take a look on this : https://openmrs.atlassian.net/wiki/spaces/docs/pages/25477199/Pull+Request+Tips |
Author
Thank you for sharing the PR tips. I have reviewed them and will make sure to follow these guidelines. Please let me know if anything needs to be updated in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced exception handling using printStackTrace() with proper SLF4J logging in WebComponentRegistrar.
Using SLF4J improves logging consistency, readability, and production-level error handling across the module.
Project builds successfully
No functional behavior changed
Only logging mechanism updated