Skip to content

Conversation

@mherman22
Copy link
Member

@mherman22 mherman22 commented Dec 6, 2024

Description of what I changed

Issue I worked on

see https://openmrs.atlassian.net/browse/FLAG-86

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@samuelmale
Copy link
Member

@mherman22 Is this contingent on openmrs/openmrs-module-webservices.rest#637? If so, shouldn't this be marked as a draft?

@mherman22 mherman22 marked this pull request as draft January 16, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants