REPORT-823: Improved the preview pages query definitions. #172
Conversation
| private Integer conceptId; | ||
|
|
||
| private Concept concept; |
There was a problem hiding this comment.
There are lots of formatting changes in this pull request. Can you discard them?
There was a problem hiding this comment.
@dkayiwa I have updated the pull request to discard the formatting changes.
* Cohort Queries * Previously, the preview page for cohort query definitions did not display enough information; only the size of the cohort was shown. * Now, the preview page for cohort query definitions shows a pageable list of patient IDs in the cohort. * Person Queries * Previously, the preview page for person query definitions displayed too much information; the table was often too long and required scrolling to see all of the entries. * Now, the preview page for person query definitions shows a pageable list of patient IDs. * The preview pages for both cohort and person query definitions now share the same style to create a consistent look among the two.
|
Did you get a chance to look at this? https://wiki.openmrs.org/display/docs/Pull+Request+Tips |
I have looked at that. Is there anything I missed? |
|
Did you read about the JIRA workflow? |
I am unsure where to find these buttons. I have made a comment on the ticket with a link to the pull request however. |
|
@dkayiwa Is there anything else I can do to finish this pull request? |
|
I have just commented on the ticket. |
|
@dkayiwa Is there anything else I can do to finish this pull request? |
2 participants
Description
Cohort Queries
Person Queries
The preview pages for both cohort and person query definitions now share the same style to create a consistent look among the two.
Issue
https://issues.openmrs.org/browse/REPORT-823
Checklist:
git pull --rebase upstream master.mvn clean packageright before creating this pull request andadded all formatting changes to my commit.