REPORT-913: Migrate to OpenMRS Platform 2.4.0 #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wikumChamith
changed the title
wikumChamith
force-pushed
the
2.4
branch
3 times, most recently
from
bf78bde to
7c50c97
Compare
Member
Author
Member
|
@wikumChamith is this any smaller than the one for 2.7? |
Member
Author
Yes, in PR for 2.7, 36 files were changed, but this only changed 25 files. |
Member
Author
wikumChamith
changed the title
mseaton
reviewed
Jun 6, 2025
Member
mseaton
left a comment
mseaton
left a comment
There was a problem hiding this comment.
Generally looks good to me I think. We will need to confirm that the module starts up and doesn't throw any errors, both in a system with the reportingcompatibility module also installed, and one without it installed.
api/pom.xml
Outdated
| <artifactId>reportingcompatibility-api</artifactId> | ||
| <version>${reportingCompatibilityVersion}</version> | ||
| <scope>provided</scope> | ||
| <scope>compile</scope> |
Member
There was a problem hiding this comment.
This should not be set to compile, but needs to stay as provided. reportingcompatibility is a separate module, not related to the reporting module.
dkayiwa
approved these changes
Jun 8, 2025
wikumChamith
added a commit
to wikumChamith/openmrs-module-reporting
that referenced
this pull request
Jun 18, 2025
* Migrate to 2.4.0 * Move api-1.9 * Merge old api modules to the main * Set the scope of reportingcompatibility to provided (cherry picked from commit e4022f6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://openmrs.atlassian.net/browse/REPORT-913