Skip to content

Conversation

@capernix
Copy link
Contributor

@capernix capernix commented Jul 1, 2025

Description of what I changed

The original setup only configured the TaskDefinitionResource2_4 with the test wrapper, and by adding the correct code, Both resources now use the same TaskServiceWrapper2_4 instance. When TaskActionResource1_8 needs to find tasks by UUID, it uses the same wrapper that has access to the test data. Both resources operate on the same underlying task collection which solves the compilation issues that results due to test failure stemming from this bug.

Issue I worked on

https://openmrs.atlassian.net/browse/RESTWS-984

Checklist: I completed these to help reviewers :)

  • [x] My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • [x] I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • [x] All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • [x] My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@wikumChamith
Copy link
Member

@capernix have you noticed the build errors?

@capernix
Copy link
Contributor Author

capernix commented Jul 2, 2025

@capernix have you noticed the build errors?

I did, but unfortunately I am not getting those errors on my local instance so I am unable to deal with it

So I am able to successfully run mvn clean package on the whole REST module and it builds successfully with this change in place

@dkayiwa
Copy link
Member

dkayiwa commented Jul 2, 2025

@capernix which operating system are you running on your local instance?

@capernix
Copy link
Contributor Author

capernix commented Jul 3, 2025

@dkayiwa I use windows

@dkayiwa
Copy link
Member

dkayiwa commented Jul 3, 2025

@capernix what does this command return for your local environment? mvn -v

@capernix
Copy link
Contributor Author

capernix commented Jul 3, 2025

@capernix what does this command return for your local environment? mvn -v

Apache Maven 3.9.9 (8e8579a9e76f7d015ee5ec7bfcdc97d260186937)
Maven home: D:\Work\apache-maven-3.9.9
Java version: 1.8.0_432, vendor: Temurin, runtime: D:\Work\jdk8\jre
Default locale: en_IN, platform encoding: Cp1252
OS name: "windows 11", version: "10.0", arch: "amd64", family: "windows"

@mseaton mseaton self-requested a review August 8, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants