SDK-376: SDK should prompt for database uri again if an invalid uri was entered#325
SDK-376: SDK should prompt for database uri again if an invalid uri was entered#325mherman22 wants to merge 4 commits intoopenmrs:masterfrom
Conversation
mseaton
left a comment
There was a problem hiding this comment.
Would be nice to see some tests around this if possible. Otherwise looks ok.
|
@mherman22 does this work if I pass invalid credentials using this command:
|
Fails with And with that error, it should prompt the user for new credentials until they get it right(limitd to 3 attempts |
Yeah. It would be better if we could avoid the whole error message and just output something like the following:
|
5d1571d to
25238ac
Compare
d91c270 to
1751f0f
Compare
Description of what I changed
Issue I worked on
see https://openmrs.atlassian.net/browse/SDK-376
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean installright before creating this pull request andadded all formatting changes to my commit.
No? -> execute the above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master