SDK-386: Added support for module based docker distribution#343
SDK-386: Added support for module based docker distribution#343Ruhanga wants to merge 12 commits intoopenmrs:masterfrom
Conversation
|
Hey @Ruhanga, so i attempted to use And when i try Am i missing something? |
|
Scratch that, i was running the command in a directory that already had openmrs-distro.properties so i guess it was overriding the command. After deleting it worked as expected. |
|
Thanks for checking this out @mherman22. Did you first clean install? You should have something along the lines: And: |
Description of what I changed
This PR introduces a feature which will allow generating a runnable distribution based on a module’s
config.xml, including the resolution of all its transitive module dependencies.The following has been done:
Introduced a lightweight utility class that helps in building a distribution by reading a module’s
config.xmlfile.Extended existing
build-distrocommand to support this functionality, allowing the specification or override of module artifacts using anincludeModulesparameter. This parameter accepts a comma-separated list of artifacts in the format groupId:artifactId:version. If the groupId is omitted, a default (e.g.,org.openmrs.module) can be assumed.The way to test this out:
Dockerfiledefinition located in thewebfolder, by commenting out or deleting the following lines since they break the build and not necessary in the end.Issue I worked on
see https://openmrs.atlassian.net/browse/SDK-386
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
I have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
I ran
mvn clean installright before creating this pull request andadded all formatting changes to my commit.
All new and existing tests passed.
My pull request is based on the latest changes of the master branch.