[SDK-396] SDK Setup fails on Linux due to Docker/IPv6 parsing error#357
[SDK-396] SDK Setup fails on Linux due to Docker/IPv6 parsing error#357MonotonousHarsh wants to merge 2 commits intoopenmrs:masterfrom
Conversation
|
@MonotonousHarsh Kindly do you have a Jira issue for this PR? If yes ensure its attached on this PR please.https://openmrs.atlassian.net/wiki/spaces/docs/pages/25477199/Pull+Request+Tips |
|
@jwnasambu Yes, I have updated the PR title to include the Jira Ticket ID (SDK-396). The CI checks are passing. Is there anything else needed before this can be reviewed? |
|
Please do not delete the PR template. It's there to make reviewer's lives easier. Without it, it's harder to understand the proposed changes. Similarly, this PR batches a number of changes for various things together into one go, which is discouraged. |
|
@ibacher Thank you for the review! I apologize for removing the PR template I am still learning the standard workflow here. I have edited the main description to restore the template format. Regarding the batched changes: I grouped them because I encountered both crashes sequentially while trying to get the SDK to run on my local Linux environment (first the IPv6 binding failure, and then the DB timeout). Would you like me to close this PR and separate these into two distinct Jira tickets and two separate PRs (one for the 127.0.0.1 binding, and one for the DB retry logic)? I am happy to do whatever makes the review process cleanest for you. |
Description of what I changed
Fixed the SDK setup process crashing on Linux environments.
This PR addresses two setup blockers I encountered sequentially on Linux:
localhostto127.0.0.1to prevent IPv6ParseAddrerrors.Socket.connecttimeout before the DB was fully ready.Issue I worked on
see https://issues.openmrs.org/browse/SDK-396
Checklist: I completed these to help reviewers :)