Fix shutdown cleanup: stop Tomcat before MariaDB, disable reloadable#115
Merged
dkayiwa merged 1 commit intoopenmrs-emr3from Feb 28, 2026
Merged
Fix shutdown cleanup: stop Tomcat before MariaDB, disable reloadable#115dkayiwa merged 1 commit intoopenmrs-emr3from
dkayiwa merged 1 commit intoopenmrs-emr3from
Conversation
- Change shutdown hook order to stop Tomcat first, then MariaDB, ensuring Tomcat can cleanly finish context cleanup before the database is killed - Set context reloadable=false since hot-reloading is unnecessary for a standalone distribution and causes extra file monitoring - Call container.destroy() after container.stop() for proper Tomcat lifecycle cleanup Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
During shutdown, errors like
NoSuchFileException: .../WEB-INF/lib/httpcore-nio-4.4.13.jaroccur because:Listener.contextDestroyed()), which try to open Hibernate sessions and load classesreloadable=truecauses unnecessary filesystem monitoring of WEB-INF/lib JARs, increasing the chance of classloader issues during shutdowncontainer.destroy()means Tomcat resources aren't fully released after stopChanges
reloadable=false: Hot-reloading is unnecessary for a standalone distributioncontainer.destroy()aftercontainer.stop(): Proper Tomcat lifecycle cleanup (stop halts components, destroy releases resources)