STAND-129: Fix build-distro SNAPSHOT resolution in 3.x Standalone

[Muta-Jonathan]

See https://openmrs.atlassian.net/browse/STAND-129

Description

Problem:

The OpenMRS SDK Maven Plugin build-distro fails for SNAPSHOT versions (e.g., 3.6.0-SNAPSHOT) in CI due to missing directories or unresolved SNAPSHOT artifacts.

Locally, builds may succeed because Maven caches artifacts, but CI consistently fails with artifact null errors.

Solution:

This PR implements a robust approach that works for both local and CI builds:

Pre-create directories for distro artifacts using maven-antrun-plugin:

<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-antrun-plugin</artifactId>
    <version>3.1.0</version>
    <executions>
        <execution>
            <id>create-directories</id>
            <phase>generate-resources</phase>
            <goals>
                <goal>run</goal>
            </goals>
            <configuration>
                <target>
                    <mkdir dir="${project.build.directory}/openmrs3x"/>
                </target>
            </configuration>
        </execution>
    </executions>
</plugin>

Configure openmrs-sdk-maven-plugin for generate-distro and build-distro:

<plugin>
    <groupId>org.openmrs.maven.plugins</groupId>
    <artifactId>openmrs-sdk-maven-plugin</artifactId>
    <version>6.5.0</version>
    <executions>
        <execution>
            <id>generate-distro</id>
            <phase>generate-resources</phase>
            <goals>
                <goal>generate-distro</goal>
            </goals>
            <configuration>
                <outputLocation>${project.build.directory}/openmrs3x</outputLocation>
                <batchAnswers>
                    <batchAnswer>Reference Application 3.x</batchAnswer>
                    <batchAnswer>${refapp.version}</batchAnswer>
                </batchAnswers>
                <testMode>true</testMode>
            </configuration>
        </execution>
        <execution>
            <id>openmrs-sdk:build-distro</id>
            <goals>
                <goal>build-distro</goal>
            </goals>
            <phase>generate-resources</phase>
            <configuration>
                <distro>${project.build.directory}/openmrs3x/openmrs-distro.properties</distro>
                <dir>${project.build.directory}/distro</dir>
            </configuration>
        </execution>
    </executions>
</plugin>

CI pre-run step:

Before running Maven goals in CI, ensure the SDK is set up non-interactively with proper settings:

- name: Pre-run OpenMRS SDK Plugin
  run: mvn org.openmrs.maven.plugins:openmrs-sdk-maven-plugin:6.5.0:setup-sdk -B --settings .github/maven-settings.xml -DinteractiveMode=false -DstatsEnabled=false

Benefits:

• Works consistently for SNAPSHOT and release versions locally and in CI.

• Eliminates artifact null errors.

• Does not change the developer workflow for local builds.

Testing:

• ✅ Local build: mvn clean package -Drefapp.version=3.6.0-SNAPSHOT succeeds.

• ✅ Local build: mvn clean package -Drefapp.version=3.6.0-SNAPSHOT succeeds.

• ✅ CI build passes after pre-running setup-sdk.

[Muta-Jonathan]

cc @wikumChamith @dkayiwa @mherman22

[dkayiwa]

Did you intentionally hard code 6.5.0?

[Muta-Jonathan]

Oh yes because by default this was fetching 5.5.4 version instead of the latest

[dkayiwa]

So we shall be updating this everytime the sdk is released?

[Muta-Jonathan]

Oh makes sense should be this way let me see how to specify it in a generic way

[Muta-Jonathan]

cc @dkayiwa this change fixes the issue

[dkayiwa]

Why do we now need this in the standalone but not in the SDK?

[Muta-Jonathan]

Because the Standalone build uses the SDK Maven plugin to generate and build the distro, it needs a pre-configured SDK environment — which the local machine already has but CI doesn’t. The SDK project itself just builds the tool, so it doesn’t require that setup to compile.