STAND-141: Openmrs-emr3 MariaDB4j version update to 3.3.1 and remove ReusableDb#96
Open
Abhisy2506 wants to merge 1 commit intoopenmrs:openmrs-emr3from
Open
Conversation
Abhisy2506
changed the title
Member
|
@dkayiwa could you be aware of anything that has hindered the CI actions from being triggered on this PR? |
Member
|
Not anything that i am aware of. |
Contributor
Author
|
Hey @Muta-Jonathan , is there anything i have to do for this PR? |
Member
|
@Abhisy2506 not really would let u know soon if there is any ... PR still in review though |
Member
|
@Abhisy2506 did you test this by compiling and then run the ouput zip file via extraction and doing a setup of the openmrs instance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
https://openmrs.atlassian.net/browse/STAND-141
Description
The purpose of this PR is to upgrade MariaDB4j to version 3.3.1 in openmrs-emr3 branch. This version already has native support for Windows file locking and data reuse, allowing us to remove the custom ReusableDB wrapper and use standard MariaDB4j API.
Solution
mariadb4jVersionto3.3.1inpom.xml.MariaDbController.javato use standard MariaDB4j API.jdbc:mariadb.ReusableDB.java.httpsto resolve Maven blocking issues.Testing
referenceapplication-standalonemodule builds successfully.zip-stagefails due to missing upstream dependencyinitializer-omod: 2.11.0-SNAPSHOT, which is unrelated to these changes).