alif/machine_spi: Fix init defaults to match new defaults. #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Let me know when it's merged upstream then I'll cherry-pick it. |
Signed-off-by: Kwabena W. Agyeman <[email protected]>
kwagyeman
force-pushed
the
kwabena/fix_alif_spi_init_defaults
branch
from
87703fd to
359658e
Compare
Member
Author
|
I think this can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of off-the-shelf MicroPython code using a machine.SPI calls init() without specifying all the arguments and assumes they have their default values if not specified.
Sent upstream: micropython#18150