Skip to content

fix wrong locale in middleware #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2024
Merged

fix wrong locale in middleware #502

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36e211e
fix locale in middleware
conico974 Sep 1, 2024
8689f31
Create silly-hounds-admire.md
conico974 Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/open-next/src/core/routing/middleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export async function handleMiddleware(
): Promise<MiddlewareOutputEvent | InternalResult> {
const { rawPath, query } = internalEvent;
const normalizedPath = normalizeLocalePath(rawPath);
// We only need the normalizedPath to check if the middleware should run
const hasMatch = middleMatch.some((r) => r.test(normalizedPath));
if (!hasMatch) return internalEvent;
// We bypass the middleware if the request is internal
Expand All @@ -67,7 +68,7 @@ export async function handleMiddleware(
const host = internalEvent.headers.host
? `https://${internalEvent.headers.host}`
: "http://localhost:3000";
const initialUrl = new URL(normalizedPath, host);
const initialUrl = new URL(rawPath, host);
initialUrl.search = convertToQueryString(query);
const url = initialUrl.toString();
// console.log("url", url, normalizedPath);
Expand Down