fix content-length incorrectly set in proxyRequest #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Discord here: https://discord.com/channels/1283128968140161065/1286094576788177059/1291327268450467893
Using rewrites with an external server currently has an issue when the server responds with a compressed response.
proxyRequestdecompresses the response, and suitably filters out thecontent-encodingheader from the response to indicate that it is not compressed. However currently it still passes through thecontent-lengthheader untouched. This means that downstream the response gets truncated to the length of the compressed response even though a decompressed response is being sent.This PR filters out the optional
content-lengthheader such that the content does not get truncated.Thanks!