Skip to content

use pkg.pr.new to publish PR prereleases #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2024
Merged

use pkg.pr.new to publish PR prereleases #536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions .changeset/snapshot
View file
Open in desktop

This file was deleted.

17 changes: 10 additions & 7 deletions .github/workflows/pre-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
name: Pre-release

on: workflow_dispatch
on:
pull_request:
branches:
- main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to filter to run this only on change on the packages/open-next folder itself.
Really not a big deal but change made to e2e would trigger this which is not really useful

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point! 👍

paths:
- packages/open-next/**

jobs:
release:
Expand All @@ -21,10 +26,8 @@ jobs:
- name: Install dependencies
run: pnpm install

- name: Check codestyle
run: pnpm lint
- name: Build package
run: pnpm -F @opennextjs/aws build
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be pnpm build if preferred, I set it to only build the aws package as the build script was failing in ci for some reason 😕

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably related to the comment i left below about pnpm


- name: Publish Pre-release to npm
run: pnpm release-snapshot
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
- name: Publish prerelease
run: pnpm exec pkg-pr-new publish --pnpm --compact './packages/open-next'
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
"@changesets/cli": "^2.22.0",
"@sladg/eslint-config-base": "1.4.1",
"eslint": "^8.47.0",
"pkg-pr-new": "^0.0.29",
"turbo": "1.10.12"
},
"engines": {
Expand Down
Loading
Loading