Skip to content

Conversation

dario-piotrowicz
Copy link
Contributor

I've noticed that in a few places the repo base is outdated

this seems generally fine as github just redirects to this repository, but it's not really that polished and can break tools such as pkg.pr.new that can rely on the package.json's repository to be correct (see #536 (comment), the PR package there doesn't work properly because of the incorrect repo in the package.json)

Copy link

pkg-pr-new bot commented Oct 10, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@537

commit: 3b0bdd3

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks.
There is a bunch of work that needs to be done in this repo to make it cleaner.
I'll create a bunch of issue and list everything that should be done

@conico974 conico974 merged commit d7dc13a into main Oct 10, 2024
3 checks passed
@conico974 conico974 deleted the dario/correct-repo branch October 10, 2024 10:50
@conico974
Copy link
Contributor

@dario-piotrowicz Looks like it is still broken.
The url set by the pkg-pr-new bot is not the correct one here, the one that works is this one : https://pkg.pr.new/opennextjs/opennextjs-aws/@opennextjs/aws@3b0bdd3

Weird thing is that it use the correct one in stackblitz

@dario-piotrowicz
Copy link
Contributor Author

@dario-piotrowicz Looks like it is still broken. The url set by the pkg-pr-new bot is not the correct one here, the one that works is this one : https://pkg.pr.new/opennextjs/opennextjs-aws/@opennextjs/aws@3b0bdd3

Weird thing is that it use the correct one in stackblitz

ok, let me see....

@dario-piotrowicz
Copy link
Contributor Author

dario-piotrowicz commented Oct 10, 2024

@conico974 oops.... it looks like I missed a spot! 😓 https://github.com/conico974/open-next/blob/185a4739607b0418b650ab077aaea567988e53bf/packages/open-next/package.json#L64

(well... only the most important one! 😅)

let me open a quick PR for that! sorry! 😓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants