fix all the various examples eslint warnings #544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| files: ["examples/**/*"], | ||
| rules: { | ||
| "unused-imports/no-unused-vars": "off", |
There was a problem hiding this comment.
I am guessing that in the examples directory you might want to keep unused vars? I'm happy to just fix the actual issues instead of disabling the rule if that's preferred 🙂
There was a problem hiding this comment.
Yeah i guess that's fine.
Everything in examples is there for e2e and as example, it make sense that we'll have unused variable sometimes.
dario-piotrowicz
changed the title
conico974
approved these changes
Oct 11, 2024
No problem! yeah I didn't want to fix all eslint warnings in one go as some might end up being controversial, and figured I could test the water first 😅 I'll try opening a new PR for the others at some point today 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that every PR is getting eslint warnings coming from the
examplesdirectory, so I figured I could open a quick PR to address them 🙂For example: https://github.com/opennextjs/opennextjs-aws/pull/543/files