Minor refactoring #554
Merged
Minor refactoring #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And a few other minor changes: - rename BuildOptions#tempDir to BuildOptions#buildDir - simplify the default OpenNext config - rename a few arguments for consistency / clarity
commit: |
vicb
commented
Oct 15, 2024
And use it (move) as the build folder
|
PR updated, ready to review |
vicb
commented
Oct 15, 2024
conico974
reviewed
Oct 15, 2024
conico974
requested changes
Oct 15, 2024
rename does not work across devices and the os tmp might be on a different device
conico974
approved these changes
Oct 16, 2024
conico974
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.